This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/cody-gateway: use keepalive/idle timeout options for Enterprise Portal#63605
Merged
Conversation
jac
approved these changes
Jul 3, 2024
Comment on lines
+47
to
+48
| opts = defaults.ExternalDialOptions(logger, | ||
| append([]grpc.DialOption{creds}, cloudRunDialOptions...)...) |
Member
There was a problem hiding this comment.
any reason to not do it this way?
Suggested change
| opts = defaults.ExternalDialOptions(logger, | |
| append([]grpc.DialOption{creds}, cloudRunDialOptions...)...) | |
| opts = defaults.ExternalDialOptions(logger, append(cloudRunDialOptions, creds)...) |
Member
Author
There was a problem hiding this comment.
It matches the callsite above where creds is first 😆
Member
Author
There was a problem hiding this comment.
Let's keep this as is and test it out - if it helps, I want to move it into the shared package as a "these are options you should use for interacting with MSP services"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://linear.app/sourcegraph/issue/CORE-203 - it seems the default keepalive and idle options are quite aggressive about keeping idle connections around without verifying them. This change tries to configure some options to ensure idle connections aren't retained for a long time.
Test plan
sg start cody-gatewaywithCODY_GATEWAY_ENTERPRISE_PORTAL_URL: https://enterprise-portal.sgdev.org:443in override