This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(sg): one-time oauth login to persist user email for analytics#63603
Merged
Conversation
71fcfb6 to
d10f5f5
Compare
jhchabran
reviewed
Jul 3, 2024
jhchabran
left a comment
Contributor
There was a problem hiding this comment.
good stuff, good catch thinking about a misformated json and handling it from the get go 🙏
Made a suggestion for the notice itself, which is a very important bit (only reason for which this isn't approved yet).
Contributor
|
@Strum355 I'll make a PR to print a warning that when in dev, a few things are disabled, I scratched my head for a minute before understanding what was going on. |
burmudar
reviewed
Jul 8, 2024
burmudar
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses OAuth flow to fetch user's email as a one-time action, persisting it in ~/.sourcegraph/whoami.json. Flow is only re-attempted if that file doesnt exist (failed to read) or if the email is empty.
Code yoinked and adapted from @nelsonjr 's code for
sg rfc🙏Test plan
Tested locally, see screenshots above
Changelog