This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Trivial additions#63601
Merged
Merged
Conversation
abeatrix
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of trivial changes I teased out of some stacked PRs.
ProviderOverride::DisplayNamefield. This will allow Sourcegraph admins who provide custom providers the ability to give them friendly names. (So that this information is available so it can be more useful than the raw ID.)Re:
ProviderOverride.DisplayName, I don't expect this to be a required field. Or even used very often. But when debugging things, it seemed more helpful than just the opaque provider string likeanthropic-via-sourcegraphoranthropic-via-aws-bedrock.Test plan
NA
Changelog
NA