Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Syntactic indexing produce scip files#63580

Merged
keynmol merged 12 commits into
mainfrom
syntactic-indexing-produce-scip-files
Jul 9, 2024
Merged

Syntactic indexing produce scip files#63580
keynmol merged 12 commits into
mainfrom
syntactic-indexing-produce-scip-files

Conversation

@keynmol

@keynmol keynmol commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

Fixes GRAPH-695

The syntactic code intel worker now actually performs indexing of repositories by piping the TAR archive stream from Gitserver straight into scip-syntax CLI, and then manually invoking the upload enqueuer.

Test plan

  • New integration test verifying that indexing worker handles the records correctly and uploads valid indexes

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jul 1, 2024
@github-actions github-actions Bot added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform labels Jul 1, 2024
@keynmol keynmol changed the title Syntactic indexing produce scip files [DO NOT MERGE] Syntactic indexing produce scip files Jul 2, 2024
@keynmol keynmol force-pushed the syntactic-indexing-produce-scip-files branch from 7589c5b to 92c2c21 Compare July 2, 2024 13:51
@keynmol keynmol force-pushed the syntactic-indexing-produce-scip-files branch from 92c2c21 to 3bd9d06 Compare July 2, 2024 13:52
@kritzcreek kritzcreek self-requested a review July 3, 2024 02:35

@kritzcreek kritzcreek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good!

Comment thread cmd/syntactic-code-intel-worker/shared/indexing_worker.go Outdated
Comment thread cmd/syntactic-code-intel-worker/shared/indexing_worker.go Outdated
Comment thread cmd/syntactic-code-intel-worker/shared/indexing_worker.go
Comment thread cmd/syntactic-code-intel-worker/shared/indexing_worker_test.go Outdated
Comment thread cmd/syntactic-code-intel-worker/shared/shared.go Outdated
Comment thread internal/uploadhandler/upload_enqueuer.go Outdated
Comment thread internal/uploadhandler/upload_enqueuer.go Outdated
Comment thread internal/codeintel/syntactic_indexing/store_test.go Outdated
Comment thread internal/codeintel/syntactic_indexing/scheduler_job.go Outdated
Comment thread cmd/syntactic-code-intel-worker/shared/indexing_worker_test.go
Comment thread internal/codeintel/syntactic_indexing/scheduler_config.go Outdated
@keynmol keynmol marked this pull request as ready for review July 4, 2024 11:59
@keynmol keynmol changed the title [DO NOT MERGE] Syntactic indexing produce scip files Syntactic indexing produce scip files Jul 9, 2024
@keynmol keynmol requested a review from kritzcreek July 9, 2024 11:16

@kritzcreek kritzcreek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this together during pairing

@keynmol keynmol merged commit 6a88bab into main Jul 9, 2024
@keynmol keynmol deleted the syntactic-indexing-produce-scip-files branch July 9, 2024 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants