This repository was archived by the owner on Sep 30, 2024. It is now read-only.
make <Label> element focus & select at end to match native label behavior#63568
Merged
Conversation
…havior When our custom `<Label>` element is labelling a contenteditable element (like a CodeMirror editor), it previously just called `element.focus()`. This focused the element but put the cursor at the start. The native and expected behavior of `<label for="...">` is to focus and put the cursor at the end. Also fix an issue where this code path would be followed even if the label had no ID, which could result in it erroneously selecting an element with an empty `aria-labelledby` attribute.
bahrmichael
approved these changes
Jul 1, 2024
vovakulikov
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When our custom
<Label>element is labelling a contenteditable element (like a CodeMirror editor), it previously just calledelement.focus(). This focused the element but put the cursor at the start. The native and expected behavior of<label for="...">is to focus and put the cursor at the end.Also fix an issue where this code path would be followed even if the label had no ID, which could result in it erroneously selecting an element with an empty
aria-labelledbyattribute.Test plan
In the create/update saved search form, click on the label and ensure it focuses at the end of the CodeMirror component.