Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(search): VSCode Search extension: Remove url and token from configuration#63559

Merged
peterguy merged 1 commit into
mainfrom
peterguy/vscode-remove-url-and-token-from-config
Jul 1, 2024
Merged

chore(search): VSCode Search extension: Remove url and token from configuration#63559
peterguy merged 1 commit into
mainfrom
peterguy/vscode-remove-url-and-token-from-config

Conversation

@peterguy

Copy link
Copy Markdown
Contributor

They are no longer used from settings.json, so they should not appear in the settings.

BEFORE

BEFORE

AFTER

AFTER

Test plan

Build and run locally

Build

git switch peterguy/vscode-remove-url-and-token-from-config
cd client/vscode
pnpm build

Run

  • Launch extension in VSCode: open the Run and Debug sidebar view in VS Code, then select Launch VS Code Extension from the dropdown menu.
  • Navigate to the Settings page (Code --> Settings... or cmd + , on macOS), search for "sourcegraph" and verify that the access token and url are no longer present in the results.

Changelog

  • Remove access token and URL from extension settings because they are managed in the extension now.

They are no longer used from settings.json, so they should not appear in the settings.
@peterguy peterguy requested a review from a team June 29, 2024 00:37
@peterguy peterguy self-assigned this Jun 29, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 29, 2024
@peterguy peterguy enabled auto-merge (squash) June 29, 2024 00:38
@peterguy peterguy changed the title Remove url and token from configuration chore(search): VSCode Search extension: Remove url and token from configuration Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants