Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(search): VSCode Search extension: Remove signup link for sourcegraph.com#63558

Merged
peterguy merged 2 commits into
mainfrom
peterguy/vscode-address-confusing-auth-ux
Jul 1, 2024
Merged

chore(search): VSCode Search extension: Remove signup link for sourcegraph.com#63558
peterguy merged 2 commits into
mainfrom
peterguy/vscode-address-confusing-auth-ux

Conversation

@peterguy

Copy link
Copy Markdown
Contributor

De-cluttering the authentication options for the VSCE. Private code is no longer hosted on sourcegraph.com, so it's confusing to be directed there.

Addresses (at least partially) #45757

Test plan

Build and run locally

Build

git switch peterguy/vscode-address-confusing-auth-ux
cd client/vscode
pnpm build

Run

  • Launch extension in VSCode: open the Run and Debug sidebar view in VS Code, then select Launch VS Code Extension from the dropdown menu.
  • See that the "Create an account" links are missing from the sidebar

Changelog

  • Remove links to create an account on sourcegraph.com because it no longer hosts private code.

De-cluttering the authentication options for the VSCE. Private code is no longer hosted on sourcegraph.com, so it's confusing to be directed there.
@peterguy peterguy requested a review from vovakulikov June 29, 2024 00:04
@peterguy peterguy self-assigned this Jun 29, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 29, 2024
@peterguy peterguy enabled auto-merge (squash) June 29, 2024 00:05
@peterguy peterguy changed the title Remove signup link for sourcegraph.com chore(search): Remove signup link for sourcegraph.com Jun 29, 2024
@peterguy peterguy changed the title chore(search): Remove signup link for sourcegraph.com chore(search): VSCode Search extension: Remove signup link for sourcegraph.com Jun 29, 2024
@peterguy peterguy requested review from a team and removed request for vovakulikov June 29, 2024 01:22
@peterguy peterguy merged commit e73709e into main Jul 1, 2024
@peterguy peterguy deleted the peterguy/vscode-address-confusing-auth-ux branch July 1, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants