This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(batch-changes): fix zero division error resulting in wrong stats computaion#63547
Merged
BolajiOlajide merged 1 commit intoJun 28, 2024
Conversation
fkling
approved these changes
Jun 28, 2024
eseliger
reviewed
Jun 28, 2024
| if noOfIncludedChangesets == 0 { | ||
| return 100 | ||
| } | ||
| return int32((mergedAndClosed / noOfIncludedChangesets) * 100) |
Member
There was a problem hiding this comment.
I was under the assumption that a division by 0 will panic 🤔
Contributor
Author
There was a problem hiding this comment.
Same. Tested in Go playground, it does not panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SRCH-636
Test plan
Added unit tests
Changelog