This repository was archived by the owner on Sep 30, 2024. It is now read-only.
add LazyQueryInputFormControl, remove duplicated common pattern#63537
Merged
Conversation
87057f5 to
19d47ec
Compare
Many places used a LazyQueryInput with a focus ring and implemented it incorrectly: - The text would overflow - The tooltips in the query input would be chopped off This cleans up duplicate code and fixes those bugs.
19d47ec to
0821d14
Compare
vovakulikov
approved these changes
Jul 2, 2024
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
I remember I had the same problem in Code Insights creation UI, with this change we probably can drop some wrappers that I wrote there as well, but this doesn't block this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many places used a LazyQueryInput with a focus ring and implemented it incorrectly:
This cleans up duplicate code and fixes those bugs.
No visual changes.
Test plan
View the query input and try overflowing it on: