This repository was archived by the owner on Sep 30, 2024. It is now read-only.
link to Cody chat on the web from the Cody manage page#63530
Merged
Conversation
Improves the Cody PLG management page to have a more prominent link to Cody Web. Also renames `Ask Cody` to `Cody` for simplicity. Closes https://linear.app/sourcegraph/issue/PRIME-396/improve-web-chat-link-on-cody-manage-page
chrsmith
approved these changes
Jun 27, 2024
| interface EditorInstructionsTile { | ||
| /** Refers to gs://sourcegraph-assets/ideIcons/ideIcon${icon}.svg. */ | ||
| icon?: string | ||
| icon?: string | React.ComponentType<{ className?: string }> |
Contributor
There was a problem hiding this comment.
Having icon be either a string or a React component seems a little awkward.
How many instances are there of <EditorInstructionsTile> in the codebase? Would it make sense to just do the larger refactoring to only take a React.ComponentType here?
Member
Author
There was a problem hiding this comment.
Yeah, def. I'll do that in a separate PR. Going to merge this page with the Cody dashboard page soon (will keep this one since this one is the one under more active maintenance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the Cody PLG management page to have a more prominent link to Cody Web. Also renames
Ask CodytoCodyfor simplicity.Closes https://linear.app/sourcegraph/issue/PRIME-396/improve-web-chat-link-on-cody-manage-page
Test plan
View in dotcom mode and ensure section looks nice