This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/sg: fix 'sg enterprise' per-command flags#63527
Merged
Merged
Conversation
jac
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
appendon a variable, then sharing that variable, surprisingly seems to cause nondeterministic behaviour in the flags. This makes the shared flag set a function so that each command gets its own set to append to.This is causing some flags to show up as non-existent in automation.
Test plan
sg enterprise subscription list -hnow has the correct flags