This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg/msp: generate github action subscription matrix dynamically#63526
Merged
Conversation
bobheadxi
reviewed
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the matrix is hardcoded in the msp repo.
Service operators can forget to add or remove their service from the list.
GitHub supports dynamically generating the matrix from a previous jobs output (example)
This PR adds an
sg msp subscription-matrixcommand which will generate the matrix we needPart of CORE-202
Test plan
Output