This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(batch-changes): remove leading and trailing spaces from batch changes credentials#63517
Merged
Merged
Conversation
Contributor
|
Good catch! |
camdencheek
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jamesmcnamara reported a number of 401s when using a PAT that had access to the repositories affected by a Batch Change. I spent some hours looking into this and was amazed by what I found.
That error was happening because there was a leading whitespace in the token in 1password and apparently the github credential validator doesn't care about whitespaces however when this token is being used to push a change, it becomes a problem because the URL now looks like this:
And that's what was calling your failing batch changes with the devx token. I'll push a fix to correct this.
Test plan
Changelog