This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(sg): reduce max interrupt count and os.Exit always#63516
Merged
Conversation
Once all the hooks have finished we now os.Exit ensuring anything else non-process related quits.
f4e970f to
be14146
Compare
BolajiOlajide
approved these changes
Jun 27, 2024
Strum355
reviewed
Jun 27, 2024
with this env var, we won't os.Exit regardless and will instead just finish the interrut routine. If sg still hangs around after this, it means something is waiting on input or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Test plan
Tested locally
Changelog