This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Marks symbols in search-based usages as definitions#63509
Closed
kritzcreek wants to merge 0 commit into
Closed
Conversation
6105d29 to
d392f39
Compare
Comment on lines
82
to
81
Contributor
There was a problem hiding this comment.
Ah this is because of "typed nil". https://go.dev/play/p/Xn8hLhjQnOb
Contributor
There was a problem hiding this comment.
Let's attach the counts for syntactic and search-based to the trace as an event (perhaps in the callers directly?)
Contributor
Author
There was a problem hiding this comment.
As we're doing this once per file wouldn't this be a bit spammy? I'd maybe roll these up into a per-request event?
Comment on lines
1288
to
1351
Contributor
There was a problem hiding this comment.
Let's log the error instead of dropping it silently?
Contributor
Author
There was a problem hiding this comment.
That would lead to us double logging any error, as we've run syntactic search already before getting to this. Still in favor of logging here?
d392f39 to
3a739ea
Compare
Contributor
Author
|
As this PR sits on top of #63464 I've fixed the feedback pertaining to that PR over there and rebased this one. |
3a739ea to
49aff24
Compare
a9baaaa to
02ccd2d
Compare
49aff24 to
62b1b0d
Compare
f3b044f to
dd036d6
Compare
a1abfe1 to
e2af623
Compare
2003fd3 to
e5d6a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/GRAPH-712/determine-usage-kind-for-search-based-usages-by-running-symbol-search
I've decided to run a separate symbol query for simplicity for now. I'll ask the search platform team if it would be more efficient to do it in a single query when I meet with them.
Test plan
Example query for the API console