This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore/enterpriseportal: add test for iam_model#63503
Merged
Merged
Conversation
jac
suggested changes
Jun 27, 2024
jac
left a comment
Member
There was a problem hiding this comment.
this doesn't look correct to me. it was passing but I don't think the assertions were actually correct
the uuids are painful to review lol 😭
Co-authored-by: James Cotter <35706755+jac@users.noreply.github.com>
jac
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the guidance in https://openfga.dev/docs/modeling/testing to craft some rudimentary IAM model tests for Enterprise Portal IAM.
Not automated for now - the model tests must be run manually:
If we end up changing the model more I'll ask around in dev-infra to see how we should automate this.
Test plan
CI and: