Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/sg: add -auto-approve option for 'sg enterprise' updates#63500

Merged
bobheadxi merged 1 commit into
mainfrom
sg-enterprise-autoapprove
Jun 27, 2024
Merged

feat/sg: add -auto-approve option for 'sg enterprise' updates#63500
bobheadxi merged 1 commit into
mainfrom
sg-enterprise-autoapprove

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

Makes destructive updates usable in automation, such as GitHub actions

Test plan

 sg enterprise subscription update-membership -subscription-instance-domain='bobheadxi.dev' --auto-approve '...'

@cla-bot cla-bot Bot added the cla-signed label Jun 26, 2024
@bobheadxi bobheadxi requested a review from a team June 26, 2024 20:49
Comment on lines +226 to +229
&cli.BoolFlag{
Name: "auto-approve",
Usage: "Skip confirmation prompts",
}),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I feel like I've seen this as --yes or --force in other systems, instead of --auto-approve

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the convention in Terraform:

terraform apply -h
Usage: terraform [global options] apply [options] [PLAN]

  Creates or updates infrastructure according to Terraform configuration
  files in the current directory.

  By default, Terraform will generate a new plan and present it for your
  approval before taking any action. You can optionally provide a plan
  file created by a previous call to "terraform plan", in which case
  Terraform will take the actions described in that plan without any
  confirmation prompt.

Options:

  -auto-approve          Skip interactive approval of plan before applying.

@bobheadxi bobheadxi merged commit 3ec64db into main Jun 27, 2024
@bobheadxi bobheadxi deleted the sg-enterprise-autoapprove branch June 27, 2024 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants