Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Enable new Cody Web by default#63493

Merged
vovakulikov merged 1 commit into
mainfrom
vk/enable-new-cody-web-by-default
Jun 26, 2024
Merged

Enable new Cody Web by default#63493
vovakulikov merged 1 commit into
mainfrom
vk/enable-new-cody-web-by-default

Conversation

@vovakulikov

Copy link
Copy Markdown
Contributor

This PR turns on the new Cody Web by default for everyone. It's still possible to opt-out to the old Cody Web with "newCodyWeb": false in your experimental features in settings.

I forgot that the dot com instance seeds its global settings and site configuration from files and
doesn't allow us to override specific settings there;

Test plan

  • Check that the new Cody Web client is available to you without any feature flag by default

@vovakulikov vovakulikov requested a review from a team June 26, 2024 17:53
@vovakulikov vovakulikov self-assigned this Jun 26, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 26, 2024
@camdencheek

Copy link
Copy Markdown
Member

Wait, why can't we set a global setting for dotcom?

@peterguy peterguy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vovakulikov

Copy link
Copy Markdown
Contributor Author

@camdencheek Dotcom uses files to set initial site and global settings, if you try to go to dotcom and change the configuration it will throw a warning that these settings were created from a file and hence can't be edited (we build dotcom with GLOBAL_SETTINGS_FILE on)

Updating global settings not allowed when using GLOBAL_SETTINGS_FILE

@vovakulikov vovakulikov merged commit 781a421 into main Jun 26, 2024
@vovakulikov vovakulikov deleted the vk/enable-new-cody-web-by-default branch June 26, 2024 18:05
@camdencheek

camdencheek commented Jun 26, 2024

Copy link
Copy Markdown
Member

Right, I we should be changing this setting there (in the file), not manually overriding it in the frontend. Otherwise, will this actually be overrideable?

@vovakulikov

vovakulikov commented Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

Otherwise, will this actually be overrideable?

This is correct, since this package Cody Web is experimental I want to have a flow where you can go back to the old Cody Web in case if some users will have problems with new one.

@camdencheek

Copy link
Copy Markdown
Member

Yep, that still works with global settings. User settings cascade with higher priority than global settings.

@camdencheek

Copy link
Copy Markdown
Member

Not a big deal though, so let's not worry about it 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants