This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: fix regexp toggle if regexp is default#63489
Merged
Merged
Conversation
I noticed that the regexp toggle doesn't work anymore if the `"search.defaultPatternType": "regexp"`. We also append `patternType:keyword` in that case which I don't think we want, because we have an UI element to indicate that keyword search is active. The question I don't know how to answer is: What should happen if regexp is the default and the user toggles keyword search off. Should we go back to "regexp" or to "standard"? Test plan: manual testing with default pattern type set to "keyword" and "regexp".
jtibshirani
approved these changes
Jun 26, 2024
jtibshirani
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this! I should've tested it. It'd be great to add a test case if it's not too hard (I am not 100% how to do this myself, as it requires triggering the toggle 🤔 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the regexp toggle doesn't work anymore if
"search.defaultPatternType": "regexp". This is related to a recent change #63410.We also append
patternType:keywordin that case which I don't think we want, because we have an UI element to indicate that keyword search is active.The question I don't know how to answer is: What should happen if
regexpis the default and the user toggles keyword search off. Should we go back toregexpor tostandard?To reproduce the original problem, just configure regexp as default and toggle regexp on/off in the search bar.
Test plan: