This repository was archived by the owner on Sep 30, 2024. It is now read-only.
saved searches: use default pattern type#63487
Merged
Merged
Conversation
This is part of the Keyword GA Project. Instead of hardcoding the pattern type to "standard" we use the default pattern type. This really only affects highlighting, because users are already forced to explicity state a pattern type by the GraphQL API. Test plan: I tested the following workflows (1) Creating a saved search from search results page (2) Creating a saved search from the user menu (3) Editing an existing saved search after the default patternType had changed
jtibshirani
approved these changes
Jun 26, 2024
jtibshirani
left a comment
Contributor
There was a problem hiding this comment.
Nice! Would it be easy to add or update a unit test? (Just always nice practice to accompany changes with test changes, to prevent regressions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the Keyword GA Project.
Instead of hardcoding the pattern type to "standard" we use the default pattern type. This really only affects highlighting, because users are already forced to explicity state a pattern type by the GraphQL API.
Test plan:
I tested the following workflows: