This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/dotcom: show subscription UUID in Enterprise Portal format#63482
Merged
Conversation
eseliger
approved these changes
Jun 26, 2024
| path={[ | ||
| { text: 'Enterprise subscriptions', to: '/site-admin/dotcom/product/subscriptions' }, | ||
| { text: productSubscription.name }, | ||
| { text: enterprisePortalID(subscriptionUUID) }, |
Member
There was a problem hiding this comment.
the URL also contains this - do we want to change that, too?
Member
Author
There was a problem hiding this comment.
The URL already uses the UUID I'm pretty sure, e.g. https://sourcegraph.com/site-admin/dotcom/product/subscriptions/92b4f1d0-3490-4d3a-bcd3-6ed3adb32d03
As for whether or not to make that also the prefixed format - I want to avoid breaking links for now, I will revisit this as we progress
Member
Author
There was a problem hiding this comment.
In routes.tsx:
{
path: '/dotcom/product/subscriptions/:subscriptionUUID',
render: props => <DotComSiteAdminProductSubscriptionPage {...props} />,
condition: () => SHOW_BUSINESS_FEATURES,
},
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "name" thing is not used anywhere for subscriptions - all internal capabilities and APIs depend use the UUID, and Enterprise Portal will use the UUID as well.
This change replaces all name/IDs with the UUID, prefixed in Enterprise Portal format, as we prepare to launch Enterprise Portal in more places (such as Cody Analytics: https://linear.app/sourcegraph/issue/CORE-101). This is particularly relevant for Cody Analytics so I can document how to find the UUID in a way that isn't "get it from the URL".
It's not super beautiful in the subscriptions list, but as we progress on the migration to Enterprise Portal I plan to replace the ID in the list with "Display name", which is a first-class citizen in Enterprise Portal.
Test plan