Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix chopped-off tooltips in code monitor query input#63478

Merged
sqs merged 1 commit into
mainfrom
sqs/fix-codemonitor-query-tooltips
Jun 26, 2024
Merged

fix chopped-off tooltips in code monitor query input#63478
sqs merged 1 commit into
mainfrom
sqs/fix-codemonitor-query-tooltips

Conversation

@sqs

@sqs sqs commented Jun 25, 2024

Copy link
Copy Markdown
Member

The tooltips for autocomplete and diagnostics in the code monitor query editor were being chopped off due to an overflow: hidden. Now they show up.

Before (note the tiny vertical border that is part of the tooltip above the text):

image

After:
image

Test plan

Hover over a diagnostic at https://sourcegraph.test:3443/code-monitoring/new and confirm the tooltip shows.

Changelog

  • Fixed an issue when creating or editing a code monitor that obscured helpful tooltips in the query editor.

@cla-bot cla-bot Bot added the cla-signed label Jun 25, 2024
@sqs sqs marked this pull request as ready for review June 25, 2024 23:06
@sqs sqs requested a review from a team June 25, 2024 23:06
@sqs sqs force-pushed the sqs/fix-codemonitor-query-tooltips branch 2 times, most recently from 1436857 to de7ae1e Compare June 26, 2024 00:12
@sqs sqs enabled auto-merge (squash) June 26, 2024 00:12
@sqs sqs force-pushed the sqs/fix-codemonitor-query-tooltips branch from de7ae1e to a3de005 Compare June 26, 2024 04:31
@sqs sqs merged commit 7396ee0 into main Jun 26, 2024
@sqs sqs deleted the sqs/fix-codemonitor-query-tooltips branch June 26, 2024 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants