This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix chopped-off tooltips in code monitor query input#63478
Merged
Conversation
camdencheek
approved these changes
Jun 25, 2024
1436857 to
de7ae1e
Compare
de7ae1e to
a3de005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tooltips for autocomplete and diagnostics in the code monitor query editor were being chopped off due to an
overflow: hidden. Now they show up.Before (note the tiny vertical border that is part of the tooltip above the text):
After:

Test plan
Hover over a diagnostic at https://sourcegraph.test:3443/code-monitoring/new and confirm the tooltip shows.
Changelog