Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

omit go:embed of big assets from sg start single-program-experimental-blame-sqs#63477

Merged
sqs merged 1 commit into
mainfrom
sqs/sg-exp-target-no-assets
Jun 25, 2024
Merged

omit go:embed of big assets from sg start single-program-experimental-blame-sqs#63477
sqs merged 1 commit into
mainfrom
sqs/sg-exp-target-no-assets

Conversation

@sqs

@sqs sqs commented Jun 25, 2024

Copy link
Copy Markdown
Member

This cuts building ./cmd/sourcegraph from ~60s to ~6s when using sg start single-program-experimental-blame-sqs (which is dev only and never needs bundled assets).

Test plan

n/a, dev experimental only

@sqs sqs requested a review from a team June 25, 2024 22:34
@cla-bot cla-bot Bot added the cla-signed label Jun 25, 2024

@camdencheek camdencheek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

…l-blame-sqs`

This cuts building `./cmd/sourcegraph` from ~60s to ~6s when using `sg start single-program-experimental-blame-sqs` (which is dev only and never needs bundled assets).
@sqs sqs force-pushed the sqs/sg-exp-target-no-assets branch from b7ce169 to 6db7bbd Compare June 25, 2024 22:58
@sqs sqs enabled auto-merge (squash) June 25, 2024 22:58
@sqs sqs merged commit f4bf9a6 into main Jun 25, 2024
@sqs sqs deleted the sqs/sg-exp-target-no-assets branch June 25, 2024 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants