Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Update free tier limits#63474

Merged
chenkc805 merged 2 commits into
mainfrom
chenkc805-patch-2
Jun 28, 2024
Merged

Update free tier limits#63474
chenkc805 merged 2 commits into
mainfrom
chenkc805-patch-2

Conversation

@chenkc805

Copy link
Copy Markdown
Contributor

Updating the Free tier limits. Context: https://linear.app/sourcegraph/issue/CODY-2553/update-cody-free-tier-to-make-it-more-appealing

Test plan

manual review

@chenkc805 chenkc805 requested a review from chrsmith June 25, 2024 20:44
@cla-bot cla-bot Bot added the cla-signed label Jun 25, 2024

@chrsmith chrsmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as updating the copy on the page, this seems fine. But have we already updated the places where we enforce those free tier limits? Off the top of my head, I don't know exactly where that logic is.

But somewhere we have 500 and 200 hard-coded and would need to update those too. Ideally before we update the text on the page.

updated models
@chenkc805 chenkc805 requested a review from chrsmith June 28, 2024 22:39
@chenkc805

Copy link
Copy Markdown
Contributor Author

@chrsmith can I get your re-review? Thank you

@chrsmith

Copy link
Copy Markdown
Contributor

The Copy is still fine, but we shouldn't merge this until we are ready to actually change the values. (Since as-is this just says we'll give users limit X, but it will remain Y.)

After looking a bit harder, it appears that these settings are defined in the Sourcegraph dotcom site configuration. Here:
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/cmd/frontend/internal/dotcom/productsubscription/codygateway_dotcom_user.go?L235-273

So let's just coordinate on when we're ready to make the config change, and then we can merge this PR and everything will "just work".

@chrsmith chrsmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you already made the site config changes. And they are totally live. So we can safely merge this now!
https://github.com/sourcegraph/deploy-sourcegraph-cloud/pull/18643/files
image

@chenkc805 chenkc805 merged commit 0e82e71 into main Jun 28, 2024
@chenkc805 chenkc805 deleted the chenkc805-patch-2 branch June 28, 2024 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants