Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(bazel): add client/backstage-frontend to bazelignore#63471

Merged
Strum355 merged 1 commit into
mainfrom
nsc/backstage-ignore
Jun 25, 2024
Merged

chore(bazel): add client/backstage-frontend to bazelignore#63471
Strum355 merged 1 commit into
mainfrom
nsc/backstage-ignore

Conversation

@Strum355

Copy link
Copy Markdown
Contributor

Addresses the following error that was missed due to not happening to me locally, see original: https://github.com/sourcegraph/sourcegraph/pull/59638

ERROR: Traceback (most recent call last):
        File "/Users/will/code/sourcegraph/client/backstage-frontend/node_modules/@sourcegraph/build-config/BUILD.bazel", line 9, column 22, in <toplevel>
                npm_link_all_packages(name = "node_modules")
        File "/private/var/tmp/_bazel_will/dcc801c077cac507d08c05a871989466/external/npm/defs.bzl", line 3214, column 13, in npm_link_all_packages
                fail(msg)
Error in fail: The npm_link_all_packages() macro loaded from @npm//:defs.bzl and called in bazel package 'client/backstage-frontend/node_modules/@sourcegraph/build-config' may only be called in bazel packages that correspond to the pnpm root package or pnpm workspace projects. Projects are discovered from the pnpm-lock.yaml and may be missing if the lockfile is out of date. Root package: '', pnpm workspace projects: '', 'client/branded', 'client/browser', 'client/build-config', 'client/client-api', 'client/codeintellify', 'client/cody-shared', 'client/cody-ui', 'client/common', 'client/eslint-plugin-wildcard', 'client/extension-api', 'client/extension-api-types', 'client/http-client', 'client/jetbrains', 'client/observability-client', 'client/observability-server', 'client/shared', 'client/storybook', 'client/template-parser', 'client/testing', 'client/vscode', 'client/web', 'client/web-sveltekit', 'client/wildcard', 'schema'

Test plan

@willdollman

Changelog

@Strum355 Strum355 requested review from a team and willdollman June 25, 2024 14:25
@cla-bot cla-bot Bot added the cla-signed label Jun 25, 2024

@willdollman willdollman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Strum355 Strum355 enabled auto-merge (squash) June 25, 2024 14:26
@Strum355 Strum355 merged commit 6cc3b61 into main Jun 25, 2024
@Strum355 Strum355 deleted the nsc/backstage-ignore branch June 25, 2024 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants