This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(bazel): don't stamp yq rule for wolfi base images#63470
Merged
Conversation
willdollman
approved these changes
Jun 25, 2024
willdollman
left a comment
Contributor
There was a problem hiding this comment.
To the extent that I understand bazel, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While staring at execution logs locally I noticed that the stamp files stable-status.txt and volatile-status.txt were inputs to targets such as
//wolfi-images/sourcegraph-base:wolfi_config, causing theseyqtargets to be executed every time--stampchanges or stable stamp vars change. I don't know how this interacts with BwoB. Will ask in the Bazel slack for clarification https://bazelbuild.slack.com/archives/CA31HN1T3/p1719324079626239Test plan
bazel buildon an oci_image target works fine, confirmed by CIChangelog