This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore/enterpriseportal: propagate context to migration database context#63455
Merged
Conversation
unknwon
approved these changes
Jun 25, 2024
| "time" | ||
|
|
||
| "github.com/openfga/openfga/assets" | ||
| openfga_migrations "github.com/openfga/openfga/assets" |
Contributor
There was a problem hiding this comment.
Suggested change
| openfga_migrations "github.com/openfga/openfga/assets" | |
| openfgaassets "github.com/openfga/openfga/assets" |
or
Suggested change
| openfga_migrations "github.com/openfga/openfga/assets" | |
| openfgaAssets "github.com/openfga/openfga/assets" |
Member
Author
There was a problem hiding this comment.
I think underscore is the standard if a space is needed - renamed to openfga_assets
Member
Author
There was a problem hiding this comment.
(openfgaassets hurts my brain 😆 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #63448 - we now get Redis spans, but not the database operations that happen throughout a migration. Maybe this will do the thing?
Test plan
n/a