This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Properly rounded corner for file view hover cards#63446
Merged
Conversation
jhchabran
approved these changes
Jun 24, 2024
BolajiOlajide
approved these changes
Jun 24, 2024
camdencheek
approved these changes
Jun 24, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Thanks!
Do you know why the tooltip styles live in here rather than defined by the hover card component?
Contributor
Author
|
@camdencheek This element is controlled by CodeMirror and some properties (like border-radius) have to be properly set all the way "to the top" for them to look properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-130
(note the corners)
Test plan
Visual inspection