This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): Properly route to revision agnostic pages#63444
Merged
Conversation
There are two kinds of repository pages: Those who depend on the revision possibly present in the URL and those who are not. This commit re-arranges the routes to better distinguish between these two types. It also adds a visual indication to the commits that the history at a specific revision is shown. Additionally it removes the revision from links to revision agnostic pages. Overall this should make it clearer to the user when and when not the revision in the URL is relevant. Note: I originally added a redirect for revision agnostic pages that would remove the revision if it was present in the URL. I decided to not do that for now because that redirect introduces an additional history entry which makes it difficult to navigate back.
camdencheek
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two kinds of repository pages: Those who depend on the revision possibly present in the URL and those who are not.
This commit re-arranges the routes to better distinguish between these two types. It also adds a visual indication to the commits that the history at a specific revision is shown. Additionally it removes the revision from links to revision agnostic pages.
Overall this should make it clearer to the user when and when not the revision in the URL is relevant.
Note: I originally added a redirect for revision agnostic pages that
would remove the revision if it was present in the URL. I decided to
not do that for now because that redirect introduces an additional
history entry which makes it difficult to navigate back.
Closes srch-600
Test plan
Manual testing.