This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(codeintel): Differentiate between paths relative to upload root vs repo root#63437
Merged
Conversation
… vs repo root This code identifies a bug in the SCIPDocument method which should be handling a conversion from the RepoRootRelativePath to an UploadRootRelativePath
fd37ed6 to
c75bb7a
Compare
kritzcreek
suggested changes
Jun 24, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
I think it's a good idea to un-stringify these.
Naming is always hard, but maybe we can find something a little shorter to reduce the clutter? How about RepoRelPath & UploadRelPath?
c75bb7a to
5e5c562
Compare
7a80a63 to
5b16f26
Compare
5b16f26 to
a7773fa
Compare
a7773fa to
6f73e68
Compare
0bc1034 to
8946600
Compare
kritzcreek
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully make the code easier to follow due to the mixture of
different kinds of paths in different places.
Test plan
TODO:
codenav is working OK - checked for
libsubdirChangelog