This repository was archived by the owner on Sep 30, 2024. It is now read-only.
config(cody): Various fixes and updating the naming rules for ModelConfig resource IDs#63436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
internal/modelconfigpackage provides the schema by which Sourcegraph instances will keep track of LLM providers, models, and various configuration settings. Thecmd/cody-gateway-configtool writes a JSON file contains the model configuration data for Cody Gateway.This PR fixes an assortment if problems with these components.
d8963da - Due to a logic error, we were saving the model ID of "unknown" into
models.json. We now put the actualModelIDfrom theModelRef.d9baa65 - Updates the model information that gets rendered, so that it matches what is hard-coded into the
sourcegraph/codyrepo. (We were missing any reference to the newly added Google Gemini models.)c28780c - Relaxes the resource ID regular expression so that it is now legal to add periods. So "gemini-1.5-latest" is now considered a valid
ModelID.... however, the validation checks were incorrectly passing because there was a bug in the regular expression. And after writing some unit tests for the
validateModelReffunction, I found several other problems with that regular expression 😅 . But we should be much closer to things working as intended now.Test plan
Added tests