Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

remove disabled web UI code for embeddings#63432

Merged
sqs merged 1 commit into
mainfrom
sqs/rm-embeddings-web-ui
Jun 24, 2024
Merged

remove disabled web UI code for embeddings#63432
sqs merged 1 commit into
mainfrom
sqs/rm-embeddings-web-ui

Conversation

@sqs

@sqs sqs commented Jun 23, 2024

Copy link
Copy Markdown
Member

Repository embeddings were removed in Feb 2024 as part of the Cody Enterprise GA. They have not been used since. Some Sourcegraph instances still running an older pre-GA version may still rely on Cody Gateway (deployed by us) for embeddings generation, but they do not rely on this UI code at all, so it is safe to remove.

No changelog entry needed since this code's UI has been disabled since Feb 2024.

Test plan

Existing tests suffice since this is removing functionality.

@sqs sqs requested review from a team and rafax June 23, 2024 05:28
@cla-bot cla-bot Bot added the cla-signed label Jun 23, 2024
Repository embeddings were removed in Feb 2024 as part of the Cody Enterprise GA. They have not been used since. Some Sourcegraph instances still running an older pre-GA version may still rely on Cody Gateway (deployed by us) for embeddings generation, but they do not rely on this UI code at all, so it is safe to remove.
@sqs sqs force-pushed the sqs/rm-embeddings-web-ui branch from ee55abe to dedbaf3 Compare June 23, 2024 20:47

@rafax rafax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked through the UI manually, everything seems to work, LGTM.

@sqs sqs merged commit 896819f into main Jun 24, 2024
@sqs sqs deleted the sqs/rm-embeddings-web-ui branch June 24, 2024 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants