This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(cody-gateway): add support for Gemini models with context cache#63413
Merged
Conversation
- Add Gemini 1.5 Flash 001 and Gemini 1.5 Pro 001 models to the config and allowed models lists - These fixed stable versions support context caching, as noted in the Google Gemini API docs
chrsmith
approved these changes
Jun 24, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Do we want to "float" gemini-1.5-latest to use ...-001, ...-002 automatically? Or do we want to treat -latest as literally the model name "latest" and have N-different ...-XXX model names floating around?
It seems like this approach isn't going to scale particularly well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PART OF https://linear.app/sourcegraph/issue/CODY-2451
CLOSE https://linear.app/sourcegraph/issue/CODY-2513
NEXT: Implement context caching in the codebase. Right now using the newly added models alone do not work with context caching.
Test plan
No feature changes. Adding new model to allow list.
Changelog