This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(cody-gateway): getAPIURL before transformBody#63406
Merged
Conversation
a388898 to
4bff03d
Compare
abeatrix
commented
Jun 20, 2024
| } | ||
|
|
||
| // Get the URL to call for the upstream provider before we transform the request. | ||
| upstreamURL := methods.getAPIURL(feature, body) |
Contributor
Author
There was a problem hiding this comment.
This was issue #1, where before this change, we would use the transformed body to getAPIURL (currently only Google uses body to build the APIURL), and in Google case, we have already stripped the Stream value, so body.Stream was always returning false.
abeatrix
commented
Jun 20, 2024
|
|
||
| // Store the shouldStream value in case it changes during the transformation. | ||
| // Example: We remove it for Google requests. | ||
| shouldStream := body.ShouldStream() |
Contributor
Author
There was a problem hiding this comment.
This is issue #2, where before this change, we would call the body.ShouldStream() that returns body.Stream value, which could have changed already during the transformBody step. Moving this before transformBody resolve the issue.
chrsmith
approved these changes
Jun 20, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
Thanks for calling out the nuance of the change. This seems reasonable.
emidoots
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the requestBody is used after transformBody has been executed.
Test plan
Changelog