Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(plg): require confirmation before removing user or revoking admin#63388

Merged
taras-yemets merged 8 commits into
mainfrom
ty/plg-team-members-confirmation-modals
Jun 20, 2024
Merged

feat(plg): require confirmation before removing user or revoking admin#63388
taras-yemets merged 8 commits into
mainfrom
ty/plg-team-members-confirmation-modals

Conversation

@taras-yemets

@taras-yemets taras-yemets commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

Closes https://github.com/sourcegraph/sourcegraph/issues/63240

Adds a confirmation modal before revoking admin or removing user.

Screenshot 2024-06-20 at 19 50 28

Screenshot 2024-06-20 at 19 50 36

Test plan

  • Run Sourcegraph instance in dotcom mode
    • Sign in as Cody Pro team site admin
    • Navigate to "/cody/team/manage" page
    • Click on remove button next to the team member
      • Ensure the confirmation modal is visible
      • Ensure clicking the cancel button closes the confirmation modal and user is not removed
      • Ensure clicking the confirm button removes the user and closes the confirmation modal
    • Click on the revoke admin button next to the team admin
      • Repeat steps for the user removal

Changelog

@taras-yemets

Copy link
Copy Markdown
Contributor Author

@rrhyne, I've just watched your Loom and now working on updating this PR accordingly (confirmation text messages, alert and button styles, etc.)

@vdavid vdavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me, and if something is off, we can iterate from here.

Comment thread client/web/src/cody/team/TeamMemberList.tsx Outdated
@taras-yemets taras-yemets enabled auto-merge (squash) June 20, 2024 16:56
@taras-yemets taras-yemets merged commit 18f42a7 into main Jun 20, 2024
@taras-yemets taras-yemets deleted the ty/plg-team-members-confirmation-modals branch June 20, 2024 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show confirmation dialog before removing a team member and revoking admin rights

2 participants