This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Improve InviteUsers interface#63383
Merged
Merged
Conversation
| const subscriptionSummaryQueryResult = useSubscriptionSummary() | ||
| const isAdmin = subscriptionSummaryQueryResult?.data?.userRole === 'admin' | ||
| const teamId = subscriptionSummaryQueryResult?.data?.teamId | ||
| const isAdmin = subscriptionSummary.userRole === 'admin' |
Contributor
There was a problem hiding this comment.
If InviteUsers is rendered only for admins we can skip isAdmin logic here.
Contributor
Author
There was a problem hiding this comment.
Well, but then the users of this component need to be aware of that requirement, which leaves room for error. I want to ensure admin privileges inside the component.
taras-yemets
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @taras-yemets's feedback on https://github.com/sourcegraph/sourcegraph/pull/63375
Test plan
Just a refactor