This repository was archived by the owner on Sep 30, 2024. It is now read-only.
plg(feat): Make page headers the same style#63380
Merged
Merged
Conversation
taras-yemets
approved these changes
Jun 20, 2024
Co-authored-by: Taras Yemets <yemets.taras@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original goal was to fix error messages being too close to headers.
This PR fixes that:
But then I noticed that several of the pages had different header styles, so I standardized them in this PR.
Note: This PR also makes sure that we use
CodyProRouteseverywhere for URLs.Test plan
Manual QA and design review.
Instead of screenshots, I showed them in this 30-sec Loom because this way it's also easier to compare them to each other and see that they are indeed the same style.