chore: Add SymbolUsageKind to GraphQL API#63371
Conversation
050e12d to
e0397af
Compare
| sound() override { ... } | ||
|
|
||
| func bark(dog: Dog): | ||
| ^-^ (1) |
Co-authored-by: Anton Sviridov <velvetbaldmime@protonmail.com>
…r off and stop complaining on my PRs
| animal.sound() | ||
| # ^---^ (1) | ||
| dog.sound() | ||
| # ^---^ (2) |
There was a problem hiding this comment.
Did you mean to move these markers up into the interface and class blocks?
There was a problem hiding this comment.
No, the (1) and (2) mark the range passed as input. When I say "usageForSymbol for (1)" I'm talking about the input range. Do you think I should add more markers and clarify or change the wording?
There was a problem hiding this comment.
The thing that tripped me up is that this is the SymbolUsageKind for definitions, and both of these markers pointed at references.
I'll have to read this again on Monday, maybe I'm misunderstanding what this is about.
There was a problem hiding this comment.
Right, so the output ranges will correspond to the declarations, but the input range may correspond to any site.
Mostly a documentation-related PR, the implementation will be done later.
Fixes https://linear.app/sourcegraph/issue/GRAPH-697/add-symbolusagekind-to-usages
Test plan
n/a
Changelog