Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

allow repo access by default on dotcom#63367

Merged
sqs merged 1 commit into
mainfrom
sqs/default-repo-access-dotcom
Jun 20, 2024
Merged

allow repo access by default on dotcom#63367
sqs merged 1 commit into
mainfrom
sqs/default-repo-access-dotcom

Conversation

@sqs

@sqs sqs commented Jun 20, 2024

Copy link
Copy Markdown
Member

Sourcegraph.com only has public repos, so it is safe to allow access to all repositories by all users.

This now-deleted code was originally added in https://github.com/sourcegraph/sourcegraph/pull/26345 to support private repositories on dotcom. We do not currently support private repositories on dotcom anymore, and when we do add back that feature, we can figure out how best to do it and will benefit from fewer special-cases for dotcom.

Test plan

CI

Sourcegraph.com only has public repos, so it is safe to allow access to all repositories by all users.

This now-deleted code was originally added in https://github.com/sourcegraph/sourcegraph/pull/26345 to support private repositories on dotcom. We do not currently support private repositories on dotcom anymore, and when we do add back that feature, we can figure out how best to do it and will benefit from fewer special-cases for dotcom.
@cla-bot cla-bot Bot added the cla-signed label Jun 20, 2024
@sqs sqs requested a review from unknwon June 20, 2024 05:24

@unknwon unknwon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sqs sqs merged commit 5685bb0 into main Jun 20, 2024
@sqs sqs deleted the sqs/default-repo-access-dotcom branch June 20, 2024 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants