feat(appliance): appliance docker container#63357
Conversation
craigfurman
left a comment
There was a problem hiding this comment.
🚀
I won't claim to know exactly how this bazel works, but thanks for doing this!
|
No worries! :) We can now build images with Docs for how the wolfi-images work are located here I'm still testing to make sure it includes all the dependencies we need, and correctly runs appliance as expected. |
| repo_tags = ["appliance:candidate"], | ||
| ) | ||
|
|
||
| wolfi_base() |
There was a problem hiding this comment.
This isnt needed if youre using //wolfi-images/sourcegraph-base:base_image, only if youve got a custom wolfi-based base image for appliance e.g. //cmd/batcheshelper has its own custom image defined in wolfi-images/batcheshelper.yaml, hence it would use wolfi_base()
There was a problem hiding this comment.
I shouldve scrolled to the next file to see you do have a custom wolfi image 😄 in that cause replace base = "//wolfi-images/sourcegraph-base:base_image", with base = ":base_image",, to reference the base image created by this wolfi_base macro invocation, unless youre fine using //wolfi-images/sourcegraph-base:base_image in which case you dont need wolfi-images/appliance.yaml
There was a problem hiding this comment.
I see, I think it's fine to use the sourcegraph-base:base_image, since I don't think there's anything custom we need to run appliance.
Working towards a standard Appliance deployment, currently none exist.
As part of REL-13 we need to create a docker container that hosts Appliance (REL-201) which this PR resolves.
Test plan
sg images build applianceChangelog