This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody pro icon was squashed in the upgrade banner#63356
Merged
Merged
Conversation
Author
|
@chrsmith Q: does this NEED a changelog entry? Is the domain correct? There is no listing of domains in the template. |
chrsmith
approved these changes
Jun 19, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
LGTM. For reference, this is what the "squashed" version looks like.
Contributor
I would just ignore it. This doesn't seem important enough to warrant calling out in the changelog. |
Author
|
Gracias! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cody PRO icon is now not squashed.
The Cody PRO icon was squashed in the upgrade banner as it was incorrectly specified in Figma.
Test plan
I will manually test to ensure the icon is not squashed in width or height.