Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(plg): migrate invoices list to react-query#63343

Merged
taras-yemets merged 1 commit into
mainfrom
ty/plg-migrate-invoices-list-to-react-query
Jun 19, 2024
Merged

chore(plg): migrate invoices list to react-query#63343
taras-yemets merged 1 commit into
mainfrom
ty/plg-migrate-invoices-list-to-react-query

Conversation

@taras-yemets

Copy link
Copy Markdown
Contributor

Migrates invoices list component to react-query.
Removes useApiCall hook as it's no longer used.

Test plan

  • Tested manually
    • run Sourcegraph isntance in dotcom mode locally
    • sign in as team admin and navigate to "cody/subscription/manage" page
    • confirm invoices list is fetched and displayed

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jun 19, 2024
@taras-yemets taras-yemets requested a review from a team June 19, 2024 13:52
Comment on lines +7 to +8
subscriptionSummary: () => [...queryKeys.subscriptions.subscription(), 'current-subscription-summary'] as const,
subscriptionInvoices: () => [...queryKeys.subscriptions.subscription(), 'invoices'] as const,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalidating subscription query should also invalidate subscription summary and invoices.

@vdavid vdavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so much neater ✨

@taras-yemets taras-yemets merged commit e617ca4 into main Jun 19, 2024
@taras-yemets taras-yemets deleted the ty/plg-migrate-invoices-list-to-react-query branch June 19, 2024 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants