This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): Simplify development for dotcom#63341
Merged
Merged
Conversation
Whether or not the app is in "dotcom mode" is determined by `window.context.sourcegraphDotComMode`. In development we use a stub `window.context` object defined in `app.html`. This commit extends that object to set `sourcegraphDotComMode` depending on an environment varible. The environment variable is set by using vite modes (https://vitejs.dev/guide/env-and-mode.html). The whole setup can be started with `pnpm dev:dotcom`.
fkling
commented
Jun 19, 2024
Contributor
Author
There was a problem hiding this comment.
This file isn't relevant anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether or not the app is in "dotcom mode" is determined by
window.context.sourcegraphDotComMode. In development we use a stubwindow.contextobject defined inapp.html.This commit extends that object to set
sourcegraphDotComModedepending on an environment varible. The environment variable is set by using vite modes (https://vitejs.dev/guide/env-and-mode.html).The whole setup can be started with
pnpm dev:dotcom.Test plan
Ran
pnpm dev:dotcomand saw the dotcom specific header and footer.