This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Data/code preloading doesn't work when using panels#63339
Merged
Conversation
The panels code prevents event propagation of mouse move events, which in turn seems to prevent SvelteKit from its own preloading logic. Looking at the event handlers it seems they are global only (per document), so I don't think that stopping the propagation is necessary for the panel itself to work. However, I think it makes sense to stop any of default event behavior when the mouse is currently pressed, since that means the user is currently dragging a resize handler.
vovakulikov
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-507
The panels code prevents event propagation of mouse move events, which in turn seems to prevent SvelteKit from its own preloading logic.
Looking at the event handlers it seems they are global only (per document), so I don't think that stopping the propagation is necessary for the panel itself to work. However, I think it makes sense to stop any of default event behavior when the mouse is currently pressed, since that means the user is currently dragging a resize handler. Would love to get @vovakulikov's confirmation that my understanding is correct.
Test plan
Manual testing. Changing the size of a panel (e.g. repo page) seems to work as expected. Hovering over a file tree entry preloads data and code now, as visible in the network tab.