This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat: Add id for CodeGraphData#63337
Merged
Merged
Conversation
camdencheek
reviewed
Jun 19, 2024
| } | ||
| repos, err := repoStore.GetByIDs(ctx, id.RepoID) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "repo for CodeGraphData value no longer exists") |
Member
There was a problem hiding this comment.
I don't think this error message is quite accurate since this could also be a network error, context canceled, etc.
Contributor
Author
There was a problem hiding this comment.
camdencheek
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/GRAPH-692/provide-id-field-on-codegraphdata
Here's a screenshot of it in action:
Test plan
Manually tested against API console. Will follow-up with automated tests later.
Changelog