This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): History suggestions should show immediately when clicking the history button#63335
Merged
fkling merged 1 commit intoJun 19, 2024
Conversation
…g the history button We are hiding suggestions until the user has interacted with the input (e.g. by clicking or typing), but, as it is not, it does not include clicking on the history button. This commit changes that.
eseliger
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-545
We are hiding suggestions until the user has interacted with the input (e.g. by clicking or typing), but, as it is not, it does not include clicking on the history button.
This commit changes that.
Test plan
Manual testing. Clicking the history button without having interacted with the search input in any other way will now show history suggestions and focus in the input.