This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Properly scope global CSS selector#63332
Merged
Merged
Conversation
The tags page contains a `:global` selector at the root level, which affects all elements that match the selector, even those not part of the page. `:global` selectors always need to be scoped one way or the other.
unknwon
approved these changes
Jun 19, 2024
Contributor
Author
|
It's unfortunate that it happened but luckily it's easy to search for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tags page contains a
:globalselector at the root level, which affects all elements that match the selector, even those not part of the page.:globalselectors always need to be scoped one way or the other.Test plan
Code inspection, trivial change.