This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Retry 404 errors from Triton#63315
Merged
Merged
Conversation
| "context" | ||
| "io" | ||
| "math" | ||
| "math/rand" |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.golang.math-random-used
rafax
referenced
this pull request
Jun 19, 2024
Switches code from https://github.com/sourcegraph/sourcegraph/pull/63315 to use [math/rand/v2](https://pkg.go.dev/math/rand/v2) as suggested by @keegancsmith. ## Test plan - tested locally with a backend throwing random 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when SMEGA scales down a pod, it will return 404 for a period of time, and that 404 will get translated into a 500 response from Cody Gateway. This PR implements (exponential) retries (with jitter), attempting to send the same request to a different Triton pod.
Closes AI-86.
Related to AI-31, AI-87.
Test plan