This repository was archived by the owner on Sep 30, 2024. It is now read-only.
syntax-highlighter: Use camino to make handling utf8 paths nicer#63311
Merged
Conversation
It's a library for paths that are Utf8 only
57aaaf1 to
4aa5243
Compare
4aa5243 to
497ca10
Compare
keynmol
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/GRAPH-688/refactor-syntax-highlighter-to-use-the-camino-library
We're already codifying and assuming that paths are utf8 only in a bunch of places. This library let's us make the utf8 check up-front and then not have to recheck over and over again.
Test plan
This should purely be a refactoring, so all existing tests should continue to pass