This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: UpdateCodyGatewayAccess RPC definition#63307
Merged
bobheadxi merged 4 commits intoJun 18, 2024
Merged
Conversation
unknwon
approved these changes
Jun 18, 2024
| // UpdateEnterpriseSubscription updates the Cody Gateway access granted to an | ||
| // Enterprise subscription. | ||
| // | ||
| // Only properties specified by the update_mask are applied. |
Contributor
There was a problem hiding this comment.
After last time we discussed in Slack based on the following
My understanding of "AIP" principle for update is:
- When the
update_maskis absent, non-empty fields are updated, e.g.
- When specified, fields are updated by the list of "path"s, e.g.
- When
*is used as "path", force update all fields, e.g.
Following that, in the RPC docstring, we'd better to say which exact paths are updatable, e.g. (you're doing it already in the PR)
All of which is to say "Only properties specified by the update_mask are applied." should be removed 😂
Member
Author
There was a problem hiding this comment.
Makes sense! I copied this from the existing UpdateEnterpriseSubscription 😛 I'll update both
Contributor
There was a problem hiding this comment.
The one for UpdateEnterpriseSubscription is taken cared in my PR, maybe just update this one so either PR merges would not create conflict 😁
…ore-154-enterprise-portal-proto-rpc-for-updating-cody-gateway-access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed RPC definition for updating Cody Gateway access, which is currently part of the
updateProductSubscriptionGraphQL mutation, via Enterprise Portal. The RPC follows patterns suggested for "update" RPCs in https://google.aip.dev/134.As an example, to use
UpdateCodyGatewayAccessto update a subscription's code completions limit:Closes CORE-154. Implementation is tracked in a follow-up (CORE-159) - for now this will just return "unimplemented".
I've also removed the "draft state" docstrings.
Test plan
CI